Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added skeleton component #795

Open
wants to merge 2 commits into
base: rc
Choose a base branch
from

Conversation

jotoh98
Copy link

@jotoh98 jotoh98 commented Oct 1, 2022

Checklist

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

  • added component
  • added tests
  • added en docs

Closes #773

@netlify
Copy link

netlify bot commented Oct 1, 2022

Deploy Preview for geist-ui ready!

Name Link
🔨 Latest commit 6d1b4c5
🔍 Latest deploy log https://app.netlify.com/sites/geist-ui/deploys/634b1b74e180590008a39dc4
😎 Deploy Preview https://deploy-preview-795--geist-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Base: 98.85% // Head: 98.85% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6d1b4c5) compared to base (8db79f6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##               rc     #795   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         198      199    +1     
  Lines        3045     3058   +13     
  Branches      669      671    +2     
=======================================
+ Hits         3010     3023   +13     
  Misses         34       34           
  Partials        1        1           
Impacted Files Coverage Δ
components/skeleton/skeleton.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@unix unix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, this component fits perfectly, it is small and enough to use. If we can fix a few issues with the comments we can merge this feature.

components/skeleton/skeleton.tsx Outdated Show resolved Hide resolved
components/skeleton/skeleton.tsx Outdated Show resolved Hide resolved
components/skeleton/skeleton.tsx Outdated Show resolved Hide resolved
@unix unix linked an issue Oct 3, 2022 that may be closed by this pull request
2 tasks
@jotoh98
Copy link
Author

jotoh98 commented Oct 15, 2022

@unix thanks for your review and sorry that you had to wait for so long. I'll fix the issues in a bit

@jotoh98 jotoh98 requested a review from unix October 18, 2022 19:24
@Geczy
Copy link

Geczy commented Nov 9, 2022

so can we merge this? its beautiful

@jotoh98
Copy link
Author

jotoh98 commented Nov 13, 2022

@Geczy I think so
@unix is there something holding the merge back?

@ghost
Copy link

ghost commented Nov 19, 2022

any eta for this merge guys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Skeleton
3 participants