-
-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use ansible_facts
rather than variables
#423
base: master
Are you sure you want to change the base?
Conversation
LGTM |
Seems like there's a merge conflict—happy to merge once that's fixed up! |
Merge conflict resolved. |
How's this looking now @geerlingguy? |
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
@geerlingguy please could you merge this one? Thanks |
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
:( |
@geerlingguy , looks like this has been ready for a year. Any chance of merging it? |
@jamesmyatt - Only reason I haven't merged is I wanted to take some time and update this across all my roles at once, for consistency... still might do that, or go ahead and merge in some roles sooner, we'll see. It doesn't really harm the roles to use the old way though. |
Makes sense. Thank you. |
This PR addresses the issue raised in #422 by replacing
ansible_
withansible_facts.
counterparts.Has been tested numerous times within Ubuntu 22.04.