Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to look up the latest docker-compose version from Github API #212

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

robinreinhardt
Copy link

This small changes add the ability to get the latest docker-compose version from Github API when docker_compose_version is "latest"

@stale
Copy link

stale bot commented Sep 17, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Sep 17, 2020
@stale
Copy link

stale bot commented Oct 17, 2020

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

@stale stale bot closed this Oct 17, 2020
@geerlingguy geerlingguy reopened this Nov 11, 2020
@geerlingguy
Copy link
Owner

I like this.

@stale
Copy link

stale bot commented Nov 11, 2020

This pull request is no longer marked for closure.

@stale
Copy link

stale bot commented Nov 11, 2020

This issue is no longer marked for closure.

@stale
Copy link

stale bot commented Nov 11, 2020

This pull request is no longer marked for closure.

@stale stale bot removed the stale label Nov 11, 2020
@jorianvo
Copy link

Please be aware that this code is now broken due to the release of compose v2 i.e. when you now try to get the latest release you'll receive a 404. This is due to the fact that in compose v2 the assets are renamed from e.g.
docker-compose-Linux-x86_64 to docker-compose-linux-amd64.

@geerlingguy
Copy link
Owner

Hmm... is there an easy way to work around that?

@robinreinhardt
Copy link
Author

Unfortunately I guess this can not be solved easily.
The download link structure is really messed up across the versions.
Here what I got so far:

version 1: version number without "v", Linux, x86_64
version 2.0.0: version with "v", linux, amd64
since version 2.0.1: version with "v", linux, x86_64

That's why it's not possible to downgrade the version from 2 to 1 like mentioned on #378

Gladly report if someone can create a logic for this link structure.

Perhaps we should consider deprecating compose version 1 in this role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants