rework label selector and resource identifier type #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reworks the parsing of the KubeSpec struct and identifying parse errors earlier (along with a line/column for the failure of `With` struct parsing). Signed-off-by: Jay Pipes <[email protected]>
Introducing the `on.fail` field for the kube gdt plugin involves parsing a kubernetes action (get, create, apply, etc) separate from the main `kube` field in the KubeSpec. So, in this patch we separate out the Action and then embed the Action struct inside the KubeSpec, separating out the parsing of the Action struct. Signed-off-by: Jay Pipes <[email protected]>
**This introduces a breaking API change**
Previously, the following YAML was used to select (or delete) resources
in a `gdt-kube` test spec:
```yaml
tests:
- kube.get: pods
with:
labels:
app: nginx
```
This functionality has been changed to use the following format instead:
```yaml
tests:
- kube:
get:
type: pods
labels:
app: nginx
```
or using the `kube.get` shortcut, like so:
```yaml
tests:
- kube.get:
type: pods
labels:
app: nginx
```
This was changed in order to better accomodate additional Kubernetes
actions coming in future PRs, including `logs` and `exec` actions, as
well as to standardize the parsing of resource identifiers and label
selectors.
Signed-off-by: Jay Pipes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a breaking API change
Previously, the following YAML was used to select (or delete) resources
in a
gdt-kubetest spec:This functionality has been changed to use the following format instead:
or using the
kube.getshortcut, like so:This was changed in order to better accomodate additional Kubernetes
actions coming in future PRs, including
logsandexecactions, aswell as to standardize the parsing of resource identifiers and label
selectors.