Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-352: Update gaffer-gremlin example #353

Merged
merged 2 commits into from
May 10, 2024
Merged

Gh-352: Update gaffer-gremlin example #353

merged 2 commits into from
May 10, 2024

Conversation

p29876
Copy link
Member

@p29876 p29876 commented May 9, 2024 •
edited by github-actions bot
Loading

GCHQDeveloper314
GCHQDeveloper314 reviewed May 9, 2024
View reviewed changes
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the files need an extra newline at the bottom

@GCHQDeveloper314 GCHQDeveloper314 merged commit b8e30b7 into develop May 10, 2024
2 checks passed
@GCHQDeveloper314 GCHQDeveloper314 deleted the gh-352-update-gaffer-gremlin-example branch May 10, 2024 15:25
@tb06904 tb06904 linked an issue May 20, 2024 that may be closed by this pull request
Improve the gaffer-gremlin example #361
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tb06904 tb06904 tb06904 approved these changes

@GCHQDeveloper314 GCHQDeveloper314 GCHQDeveloper314 approved these changes

@cn337131 cn337131 Awaiting requested review from cn337131

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the gaffer-gremlin example Gaffer-Gremlin example schema broken
3 participants
@p29876 @GCHQDeveloper314 @tb06904