Innovation time - Github markdown model card details code highlighting #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
Needs to have a custom theme for hightlight.js for WCAG accessibility with an appropriate contract ratio. |
ARADDCC012
requested changes
Oct 25, 2024
| @@ -58,7 +58,8 @@ | |||
| "swagger-ui-react": "^5.17.14", | |||
| "swr": "^2.2.5", | |||
| "typescript": "5.5.3", | |||
| "uuid": "^10.0.0" | |||
| "uuid": "^10.0.0", | |||
| "react-syntax-highlighter": "15.5.0" | |||
There was a problem hiding this comment.
I'd expect there to be accompanying package-lock.json changes with installing a new package. Make sure those changes are also committed
| <Box | ||
| component='code' | ||
| sx={{ | ||
| backgroundColor: theme.palette.grey[200], |
There was a problem hiding this comment.
We should use a theme colour that works in both light and dark modes. A static colour will not work for both.
| }} | ||
| {...props} | ||
| > | ||
| {language ? <SyntaxHighlighter language={language}>{children}</SyntaxHighlighter> : children} |
There was a problem hiding this comment.
Check that all colours used by this package conform to accessibility contrast requirements for both light and dark mode themes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.