Update command_maker.py #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add delete option from command
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hey there! Thanks for the pull request! Could you elaborate a bit more on the use case? Maybe provide an example of how this argument is supposed to work. Thanks! |
|
Hi man, folow de link with explanation
https://linux.die.net/man/1/rsync
…--delete delete extraneous files from dest dirs
--delete-before receiver deletes before transfer (default)
--delete-during receiver deletes during xfer, not before
--delete-delay find deletions during, delete after
--delete-after receiver deletes after transfer, not before
--delete-excluded also delete excluded files from dest dirs
WILSON ROBERTO PALHARES
Especialista de Sistemas de TI
TI - Desenvolvimento
Contato: (065)3645-8000 | Ramal: 8796
Escritorio Cuiaba | Cidade: Cuiaba - MT
[http://wkf.bomfuturo.com.br/assinatura.png]
________________________________
De: Gabriel Chamon Araujo ***@***.***>
Enviado: sexta-feira, 17 de novembro de 2023 17:25
Para: gchamon/sysrsync ***@***.***>
Cc: WILSON ROBERTO PALHARES ***@***.***>; Author ***@***.***>
Assunto: Re: [gchamon/sysrsync] Update command_maker.py (PR #35)
Você não costuma receber emails de ***@***.*** Saiba por que isso é importante<https://aka.ms/LearnAboutSenderIdentification>
Atenção: Esse é um e-mail externo e pode ser malicioso. Por favor tenha cuidado ao clicar em links e abrir anexos. Qualquer duvida favor procurar o departamento de Ti.
Hey there! Thanks for the pull request?
Could you elaborate a bit more on the use case? Maybe provide an example of how this argument is supposed to work. Thanks!
—
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AS64GPMNIEPX227HNLWMLNLYE7I5VAVCNFSM6AAAAAA7QMDVWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGEZDOMJWHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I am sorry, I wasn't clear about what I wanted. I understand that delete is an option in the underlying rsync command. What I really wanted to know is how this option would be used in the context of this package. Should it be exposed in the Also, I don't see how this pull request passes Maybe you could add this information to the readme.md and add tests to illustrate the use. If you don't have time, please outline how should I write the tests and the examples for the readme.md. Thanks again for the interest in this project! |
|
I understand the need for more evidence. In this case without the option --delete, the extra files are not deleted, generating a volume of garbage at the destination,.
But that's ok, due to the lack of time to better demonstrate it, I am using the subprocess.run command to help me at this time, thank you for the feedback man.
WILSON ROBERTO PALHARES
Especialista de Sistemas de TI
TI - Desenvolvimento
Contato: (065)3645-8000 | Ramal: 8796
Escritorio Cuiaba | Cidade: Cuiaba - MT
[http://wkf.bomfuturo.com.br/assinatura.png]
…________________________________
De: Gabriel Chamon Araujo ***@***.***>
Enviado: sábado, 18 de novembro de 2023 09:14
Para: gchamon/sysrsync ***@***.***>
Cc: WILSON ROBERTO PALHARES ***@***.***>; Author ***@***.***>
Assunto: Re: [gchamon/sysrsync] Update command_maker.py (PR #35)
Você não costuma receber emails de ***@***.*** Saiba por que isso é importante<https://aka.ms/LearnAboutSenderIdentification>
Atenção: Esse é um e-mail externo e pode ser malicioso. Por favor tenha cuidado ao clicar em links e abrir anexos. Qualquer duvida favor procurar o departamento de Ti.
I am sorry, I wasn't clear about what I wanted. I understand that delete is an option in the underlying rsync command. What I really wanted to know is how this option would be used in the context of this package. Should it be exposed in the run command? Must the user always use get_rsync_command to use it?
Also, I don't see how this pull request passes --delete to the final list of flags. Have you tested this modification?
Maybe you could add this information to the readme.md and add tests to illustrate the use. If you don't have time, please outline how should I write the tests and the examples for the readme.md.
Thanks again for the interest in this project!
—
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AS64GPPGPWVRIRZF7G36EI3YFCYEBAVCNFSM6AAAAAA7QMDVWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGUYDMNRVHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add delete option from command