Add support for implicit maxspeed #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #1153 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 24 24
Lines 2436 2437 +1
=======================================
+ Hits 2387 2388 +1
Misses 49 49 ☔ View full report in Codecov by Sentry. |
gboeing
requested changes
Mar 30, 2024
There was a problem hiding this comment.
Thanks for this suggestion @nikita03565. I think you're right that handling these implicit values would be useful. I've left one comment for a requested change.
gboeing
approved these changes
Apr 1, 2024
|
The first pre-release OSMnx v2 beta has been released. Testers needed! See #1123 for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refers to #1152
Added implicit speed mapping scraped from osm wiki to settings module
Updated
_clean_maxspeedmethod to get values from that mapping if parsing as number fails