Note that the day header hook receives a Date generated in UTC. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjkip
commented
Jul 4, 2024
For day headers that do not represent specific dates, like weekdays in a month view, the provided `Date` instant must be interpreted as UTC. If not done so, day headers may show the wrong weekday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the
Intlfacility to render day headers in users' locales. This renders dates in the user's time zone, whereas the providedDatewas created in UTC. This caused a surprise for users "west" of UTC, where the day header rendered a day previous. People living in +13:00 would have seen the day after!Happy to make any adjustments to the changes or the commit message!