Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versions #488

Merged
merged 12 commits into from
Nov 15, 2024
Merged

update versions #488

merged 12 commits into from
Nov 15, 2024

Conversation

martindurant
Copy link
Member

No description provided.

@cmp0xff
Copy link
Contributor

cmp0xff commented Nov 15, 2024

https://github.com/martindurant/adlfs/blob/569f9196956bf1cfef66f49d13650af19a2f1dfa/adlfs/spec.py#L1569

It seems we can write

            expiry=datetime.now(timezone.utc) + timedelta(seconds=expires),

The proposal comes from the fact that most of the warning

DeprecationWarning: Testing an element's truth value will raise an exception in future versions.  Use specific 'len(elem)' or 'elem is not None' test instead.

is related to datetime.utcnow(), from my Google search.

@martindurant
Copy link
Member Author

I already fixed one here.

But there are still some warnings coming from dep packages, which I think we should ignore for the "earliest" run.

Copy link
Contributor

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And as @martindurant has written in #488 (comment), maybe for py312 we need to xfail some tests for the earliest requirements.

os: [ubuntu-20.04]
pyv: ["3.8"]
os: [ubuntu-22.04]
pyv: ["3.12"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert in devops, but maybe we want to run tests on older Python versions as well? py39 is still being supported.

Suggested change
pyv: ["3.12"]
pyv: ["3.9", "3.10", "3.11", "3.12", "3.13"]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make 5x3=15 CI runs. Probably we should test all those python versions with "earliest", but only 3.12 for "latest" and "dev".

.github/workflows/tests.yml Outdated Show resolved Hide resolved
fsspec==2023.12.0
azure-core==1.28.0
azure-datalake-store==0.0.53
azure-storage-blob==12.17.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, they will support more recent too, but at the time of release they were not explicitly tested with a later python (they come quite frequently these days).


file_exs = await asyncio.gather(
*([cc.delete_blob(file) for file in files]), return_exceptions=True
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is another warnings.simplefilter("error") deeply hidden inside cc.delete_blob, our simplefilter("ignore") will possibly be overridden. This could possibly be the reason why it did not fix the pipeline.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt that's happening - I would reckon it's in the invocation of the interpreter. I can't find out where that's being defined, though!

@martindurant martindurant merged commit 4cf4c85 into fsspec:main Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants