forked from Netflix/conductor
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging debug #24
Open
kartik2k
wants to merge
28
commits into
freshservice_staging
Choose a base branch
from
staging_debug
base: freshservice_staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Staging debug #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhakaranE6157
previously approved these changes
May 10, 2024
prabhakaranE6157
previously approved these changes
May 20, 2024
* [FS-166971] : Fixing Prom Metrics * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fixing verions * fixing * fix * fix * fix * fix with boot CommandLineRunner * fix * fix * fix * fix * fix * custom metrics scraper endpoint * fix * fix * fix * fix * using default registry * Revert "using default registry" This reverts commit c864ea9. * fix * Revert "fix" This reverts commit 86c9314. * fix * fix * fix * fix * fix * fix * cleanup * not needed metrics * not needed metrics * this is handled in another pr reverting * auto wired deprecated fix * not needed metrics --------- Co-authored-by: Rakesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is
1- To avoid any workflow status updates if at all workflow status is updated to COMPLETED from scylla-persistence layer.
2- Separate the conductor bg and main pod processing
3- Standardise the refresh intervals
4- Added the conductor archival changes to archive the workflows execution data if successfully completed.
Need to add below secrets for the same -
WORKFLOW_ARCHIVAL_TTL_DURATION - 600
WORKFLOW_ARCHIVAL_DELAY_DURATION - 60