Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New secrets format based on Config::General for named connections. #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fozzmoo
Copy link
Contributor

@fozzmoo fozzmoo commented Dec 9, 2013

This is a rework of a previous attempt to create readonly database handles. While the previous work provided for backwards compatibility for the current secrets file format, this does not. There is now new code in freeside-upgrade that migrates from the old format to the new Config::General-based format.

@freeside
Copy link
Owner

freeside commented Jan 9, 2014

For reference:

Please see: #17 (comment)

@freeside
Copy link
Owner

No general technical issues with this change, but this is a significant plumbing change without any actual usage in the application itself.

To merge into the open-source project (and thus ask everyone else to carry the maintenance and migration cost), we'd ask that you share a more complete change including the code changes which enable you to use read-only slaves effectively.

t doesn't seem very fair of us to merge just the low-level ability to connect to different databases into master without also including the code to make useful use of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants