test: Try to fix flaky tests (#2198)

changelog.d/20241024_234611_github-actions[bot]_fix-flaky-tests.rst

@@ -0,0 +1,7 @@
+.. _#2198:  https://github.com/fox0430/moe/pull/2198
+
+Fixed
+.....
+
+- `#2198`_ test: Try to fix flaky tests
+

src/moepkg/settings.nim

@@ -678,7 +678,8 @@ proc initLspServerSettings(): LspServerSettings =
   result.rustAnalyzer = initLspRustAnalyzerSettings()
 
 proc initLspSettings(): LspSettings =
-  result.enable = true
+  when not defined unitTest:
+    result.enable = true
 
   result.features = initLspFeatureSettings()
 

tests/texmode.nim

@@ -195,6 +195,8 @@ suite "Ex mode: Write command":
       const Command = @[ru"w"]
       status.exModeCommand(Command)
 
+      discard lspClient.kill
+
 suite "Ex mode: Change next buffer command":
  test "Change next buffer command 1":
    var status = initEditorStatus()

tests/tlspclient.nim

@@ -17,7 +17,7 @@
 #                                                                              #
 #[############################################################################]#
 
-import std/[unittest, importutils, os, osproc, options, tables, json]
+import std/[unittest, importutils, os, osproc, options, tables, json, strformat]
 
 import pkg/results
 
@@ -93,12 +93,22 @@ suite "lsp: restart":
     Command = "nimlangserver"
     Trace = TraceValue.verbose
 
-  var client: LspClient
+  var
+    client: LspClient
+    beforePid: int
 
   setup:
+    beforePid = -1
+
     if isNimlangserverAvailable():
       client = (waitFor initLspClient(Command)).get
 
+  teardown:
+    if beforePid > -1:
+      discard execCmd(fmt"kill -9 {$beforePid}")
+
+    discard client.kill
+
   test "Basic 1":
     if not isNimlangserverAvailable():
       skip()
@@ -107,9 +117,9 @@ suite "lsp: restart":
       let params = initInitializeParams(ServerName, "/", Trace)
       check (waitFor client.initialize(BufferId, params)).isOk
 
-      let
-        beforePid = client.serverProcessId
-        beforeLogLen = client.log.len
+      beforePid = client.serverProcessId
+
+      let beforeLogLen = client.log.len
 
       check client.running
 
@@ -1183,6 +1193,8 @@ suite "lsp: Send requests":
     if dirExists(rootDir):
       removeDir(rootDir)
 
+    discard client.kill
+
   test "Send initialize":
     if not isNimlangserverAvailable():
       skip()

tests/tlsphandler.nim

@@ -1883,11 +1883,11 @@ suite "lsp: handleLspResponse":
       assert status.lspInitialize(workspaceRoot, LangId).isOk
 
       var isTimeout = true
-      for _ in 0 .. 100:
-        const Timeout = 100
+      for _ in 0 .. 120:
+        const Timeout = 1000
         let readable = lspClient.readable(Timeout).get
         if not readable:
-          sleep 100
+          sleep 1000
         else:
           status.handleLspResponse