Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug in Wrong link on iPhone 16 with 512GB Link #128

Closed

Conversation

pukarlamichhane
Copy link

What does this PR do?
This PR fixes a broken link in the "Prizes" section on the homepage. The link for 'iPhone 16 with 512GB' incorrectly points to the iPad landing page instead of the intended iPhone 16 page.

Fixes # (issue)

The broken link has been corrected to point to https://www.apple.com/iphone-16/.
How should this be tested?
Visit https://oss.gg/
Navigate to the "Prizes" section.
Click on 'iPhone 16 with 512GB.'
Verify that you are redirected to the correct iPhone 16 landing page.
Checklist
Required
Filled out the "How to test" section in this PR
Read How we Code at oss.gg
Self-reviewed my own code
Commented on my code in hard-to-understand bits
Ran pnpm build
Checked for warnings, there are none
Removed all console.logs
Merged the latest changes from main onto my branch with git pull origin main
My changes don't cause any responsiveness issues
Appreciated
If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Formbricks Docs if changes were necessary
Issue Summary
The link for 'iPhone 16 with 512GB' points to the iPad landing page instead of the iPhone 16 landing page on the homepage.

Steps to Reproduce
Visit https://oss.gg/
Explore the "Prizes" section.
Click on 'iPhone 16 with 512GB.'
Observe that you are redirected to the iPad landing page.
Expected behavior
The link should point to https://www.apple.com/iphone-16/.

Other information
No additional information.

Copy link

vercel bot commented Oct 7, 2024

@pukarlamichhane is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Oct 7, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fix the bug in Wrong link on iPhone 16 with 512GB Link". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant