clarificiation of minimum order quantity - currency independant

[mjavurek]

The German translation for minimum order quantity is changed:

"Wert" repräsentiert für mich eher einen Geldbetrag als "Menge", daher wird die deutsche Übersetzung aus meiner Sicht klarer.

Additionally, a currency symbol is displayed for the minimum order quantity in following locations:

• supplier edit form: as placeholder in the input field
• supplier show
• order form

[wvengen]

Thank you for your PR! I have been confused by the meaning of this. The field is called quantity, but at some point someone added some logic related to monetary amount. I have used it in the past for a textual description. And indeed, the field is a string, as can be seen in https://github.com/foodcoops/foodsoft/blob/master/db/schema.rb#L473. This is not an ideal situation.

Maybe we need to find clarity on its use in the (user) mailing-list. And introduce a monetary field separate from a 'free-form' quantity field (if it is used at all). Perhaps there are other uses (e.g. weight or crates or whatever).

[twothreenine]

I'd suggest adding a text field order_note to supplier, which prefills the order_note field of each order opened for this supplier. This could be used for various information like minimum order quantity in crates etc., transport cost, link to supplier's website etc. (Additionally, we could also extend the custom fields feature for data like this, but that would take more work.)

Then we could migrate minimum order quanitity to a monetary field (rename it to minimum order value?), detect all non-numeric data saved in it, and move it into order_note (with the respective locale of minimum order quantity).

[paroga]

I'd suggest adding a text field order_note to supplier, which prefills the order_note field of each order opened for this supplier.

What's the benefit compared to copying the order? If we add a order_note to the Order I'd prefer to add it in addition to the existing note.

I like the idea of extending the custom fields to the supplier and your migration path for existing data.

[twothreenine]

Sorry, I meant a field supplier.order_note which prefills / acts as a default for the order.note. (In addition to the existing supplier.note)

What's the benefit compared to copying the order? If we add a order_note to the Order I'd prefer to add it in addition to the existing note.

You wouldn't have to click "copy" each time and could open orders normally, while you would still be able to adapt it in case the conditions differ for a specific order. (Also, copying an order does not copy the note atm)
What's the benefit of an additional order.order_note field?