-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API-5: documentation and specs #576
Conversation
9b0f564
to
947e6c1
Compare
947e6c1
to
bea731c
Compare
i'd like to have the changes on the existing test in it's own commit, add the tests in the same commit as the controllers. why didn't you add the required column not in the first commit? |
I could add the specs in separate commits if you like. I agree that would have been nicer. When writing, it felt like an additional feature (docs, then specs based on the docs), but you're right. I'll refactor it and create a separate PR / add it to the existing PRs. I only discovered about the missing column when some condition in specs were hit, which didn't happen in the original PR but because of splitting I ended up with a newer version of Doorkeeper (which is good, but if I'd realized, I'd tested that better). Somehow the missing column didn't matter when using the API. |
i'd go for updating to Doorkeeper5 first and then rebasing all other stuff on top of it |
In hindsight I was too fast merging the earlier PRs ... |
Part five of #429 in chunks, continued from #573:
To render the swagger file, see here.