Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

article file import via plugin #1023

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

yksflip
Copy link
Member

@yksflip yksflip commented Aug 23, 2023

No description provided.

@yksflip yksflip added this to the 4.9 milestone Aug 23, 2023
@wvengen
Copy link
Member

wvengen commented Oct 15, 2023

Super to get this within Foodsoft! Especially relevant for foodcoops running their own instance not having to setup sharedlists in some scenario's.

Part of me thinks this is a good candidate for making this part of Foodsoft core, not a plugin.
Also, code is duplicated with sharedlists: what about making the file-related parts a gem, used by Foodsoft and sharedlists?
In any case, these can be additional improvements - happy to see this coming to Foodsoft, one way or another 🎉

@yksflip
Copy link
Member Author

yksflip commented Oct 15, 2023

thanks willem! :)
I think I picked the wrong branch, viehlieb actually already build a gem for this: https://git.local-it.org/Foodsoft/foodsoft_article_import
and I think 11_bnn_import_article_update should be the right branch :o

Lentschi is working atm on a "share supplier via url" feature within the foodcoopsat fork, that could supersede the sharedlists application, see: foodcoopsat/foodsoft_hackathon#20

@wvengen
Copy link
Member

wvengen commented Oct 15, 2023

Ah, super to hear! 🚀

@yksflip yksflip modified the milestones: 4.9, 5.1 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants