Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent layout shift on load by mounting codemirror styles earlier #3092

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Nov 8, 2024

#2885 introduced a layout shift on load, fixed in this PR

I did not notice the issue in #2885 because the file picker at the top of the notebook (codemirror) triggered the styles to mount. But when notebooks are viewed on the web, the styles are not mounted, and the ssr fake had no default cm styling.

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="prevent-layout-flash-codemirror-loading")
julia> using Pluto

@fonsp fonsp added bug Something isn't working frontend Concerning the HTML editor performance publishing Notebooks as static documents on the web labels Nov 8, 2024
@fonsp fonsp merged commit 368f217 into main Nov 8, 2024
7 checks passed
@fonsp fonsp deleted the prevent-layout-flash-codemirror-loading branch November 8, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Concerning the HTML editor performance publishing Notebooks as static documents on the web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant