Add Singapore public holidays #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 24, 2023
derTobsch
added
type: enhancement
XSpielinbox
force-pushed
the
pr6
branch
2 times, most recently
from
96a6d52
to
c9a6e3e
Compare
XSpielinbox
force-pushed
the
pr6
branch
2 times, most recently
from
afe3b18
to
408c544
Compare
Signed-off-by: XSpielinbox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎁 Adds support for Singapore
However, it is missing translations at the moment, as I did not know how to translate them.
Also as long as there is no support for the Tamil and/or Hindu Calendar (see #282), one has to manually define many holidays, which is very time consuming and error prone.
Additionally as long as there is no support for the Chinese Calendar (see #285), one has to manually define many holidays, which is very time consuming and error prone.
Please merge this PR AFTER #279.