-
-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add adr template and for adr for empty subdivisions
- Loading branch information
Showing
4 changed files
with
59 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Document empty subdivision | ||
|
||
## Status | ||
|
||
Accepted | ||
|
||
## Context | ||
|
||
This decision arises from the discussion on https://github.com/focus-shift/jollyday/pull/388, where the identification for subdivisions was changed to 'ISO 3166-2'. There was uncertainty regarding whether to include subdivisions that do not have additional holidays compared to the country. | ||
|
||
During the discussion, it was noted that having numerous subdivisions for a country like India while missing a few could lead to confusion and require significant time investment to identify the missing ones. | ||
|
||
## Decision | ||
|
||
The decision has been made to include all subdivisions, regardless of whether they have distinct holidays compared to the country. | ||
|
||
## Consequences | ||
|
||
For subdivisions without separate public holidays, an empty `SubConfigurations` will still be created. For instance, for `Ladākh`, it will appear as follows in the configuration: | ||
|
||
```xml | ||
<SubConfigurations hierarchy="la" description="Ladākh"> | ||
<Holidays/> | ||
</SubConfigurations> | ||
``` | ||
|
||
This ensures consistency and completeness in the documentation of subdivisions. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# Decision record template | ||
|
||
# Title | ||
|
||
## Status | ||
|
||
What is the status, such as proposed, accepted, rejected, deprecated, superseded, etc.? | ||
|
||
## Context | ||
|
||
What is the issue that we're seeing that is motivating this decision or change? | ||
|
||
## Decision | ||
|
||
What is the change that we're proposing and/or doing? | ||
|
||
## Consequences | ||
|
||
What becomes easier or more difficult to do because of this change? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# Architecture decision record (ADR) | ||
|
||
Welcome to the directory dedicated to housing the defined architectural decisions for Jollyday. | ||
|
||
For further insights and details, please refer to the [ADR List] provided in the top-level README document. | ||
|
||
Additionally, if you wish to utilize our standardized template for recording architectural decisions, | ||
it is conveniently accessible at [ADR Template]. | ||
|
||
[ADR List]: ../README.md | ||
[ADR Template]: 999-adr-template.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters