jackson: performane improvements - static xmlutil and XmlMapper

focus-shift · Nov 11, 2024 · 3ee13ce · 3ee13ce
1 parent 5f49bb6
commit 3ee13ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...ay-jackson/src/main/java/de/focus_shift/jollyday/jackson/JacksonConfigurationService.java b/...ay-jackson/src/main/java/de/focus_shift/jollyday/jackson/JacksonConfigurationService.java
@@ -10,7 +10,7 @@
 
 public class JacksonConfigurationService implements ConfigurationService {
 
-  private final XMLUtil xmlUtil = new XMLUtil();
+  private static final XMLUtil xmlUtil = new XMLUtil();
 
   @Override
   public Configuration getConfiguration(ManagerParameter parameter) {

diff --git a/jollyday-jackson/src/main/java/de/focus_shift/jollyday/jackson/XMLUtil.java b/jollyday-jackson/src/main/java/de/focus_shift/jollyday/jackson/XMLUtil.java
@@ -11,7 +11,7 @@
 
 public class XMLUtil {
 
-  private final JacksonMapperCreator mapper = new JacksonMapperCreator();
+  private static final XmlMapper mapper = new JacksonMapperCreator().create();
 
   /**
    * Unmarshalls the configuration from the stream. Uses <code>jackson</code> for
@@ -22,7 +22,7 @@ public class XMLUtil {
    */
   public Configuration unmarshallConfiguration(InputStream stream) {
     try {
-      return mapper.create().readValue(stream, Configuration.class);
+      return mapper.readValue(stream, Configuration.class);
     } catch (Exception e) {
       throw new IllegalStateException("Cannot parse holidays XML file.", e);
     }