This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Added script and compiler option to run admin in debug mode #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prafulla Mahindrakar [email protected]
TL;DR
Running admin in debug mode requires the compiler output to have debug bits.
Added a new Makefile target compile_debug which does this and the script debug.sh uses dlv to run the admin in debug mode for the serve option
Similarly the script can be modified to run for other commandline options exposed by flyteadmin
Pre-reequisite:
Install dlv : https://github.com/go-delve/delve/blob/master/Documentation/installation/README.md
Setup IDE Debug configuration. The port for DLV should match
eg
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/