Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][DO NOT MERGE] Remove LiteralTypeForLiteral by creating IsInstance function #5909

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

fix merge

715d830
Select commit
Loading
Failed to load commit list.
Open

[WIP][DO NOT MERGE] Remove LiteralTypeForLiteral by creating IsInstance function #5909

fix merge
715d830
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 13, 2024 in 0s

22.23% (-14.73%) compared to f20b8aa

View this Pull Request on Codecov

22.23% (-14.73%) compared to f20b8aa

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.23%. Comparing base (f20b8aa) to head (715d830).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f20b8aa) and HEAD (715d830). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (f20b8aa) HEAD (715d830)
unittests-flyteidl 1 0
unittests-datacatalog 1 0
unittests-flytectl 1 0
unittests-flytestdlib 1 0
unittests-flyteplugins 1 0
unittests-flytepropeller 1 0
unittests-flyteadmin 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5909       +/-   ##
===========================================
- Coverage   36.95%   22.23%   -14.73%     
===========================================
  Files        1310        8     -1302     
  Lines      131464      796   -130668     
===========================================
- Hits        48587      177    -48410     
+ Misses      78656      591    -78065     
+ Partials     4221       28     -4193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.