Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PL-132065] provision devhost with a certain release #449

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

PhilTaken
Copy link
Member

@PhilTaken PhilTaken commented Apr 11, 2024

Implement a new key for the environment file to provision devhosts based on environments or releases of those.

The new scheme is

[provisioner:default]
release=https://my.flyingcircus.io/releases/metadata/fc-23.11-staging

The use of these URLs allows using either the latest version of an environment or some specific release.

@PhilTaken PhilTaken requested a review from ctheune as a code owner April 11, 2024 11:48
@PhilTaken PhilTaken requested a review from leona-ya April 11, 2024 11:53
@ctheune ctheune force-pushed the phil/PL-132065_devhost-provision-via-release branch from 4e43ddc to 883051d Compare June 21, 2024 13:57
@ctheune ctheune requested a review from zagy as a code owner June 21, 2024 13:57
@PhilTaken PhilTaken force-pushed the phil/PL-132065_devhost-provision-via-release branch from 883051d to f1cc206 Compare July 24, 2024 07:19
@leona-ya leona-ya force-pushed the phil/PL-132065_devhost-provision-via-release branch 4 times, most recently from fe584cf to 41426cc Compare August 27, 2024 09:47
zagy
zagy previously requested changes Sep 10, 2024
Copy link
Member

@zagy zagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog missing

@leona-ya leona-ya force-pushed the phil/PL-132065_devhost-provision-via-release branch from 41426cc to 5b1f84a Compare September 10, 2024 09:42
@leona-ya leona-ya requested a review from zagy September 10, 2024 10:00
@elikoga elikoga dismissed zagy’s stale review October 15, 2024 03:28

changelog was added

@elikoga elikoga force-pushed the phil/PL-132065_devhost-provision-via-release branch from ea8c134 to 160f576 Compare October 29, 2024 09:29
@elikoga
Copy link
Member

elikoga commented Oct 29, 2024

Rebased on top of #479 and moved the changelog to a scriv changelog file in order to avoid Merge conflicts

@zagy zagy merged commit a2f0511 into main Oct 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants