Merge pull request #472 from flyingcircusio/phil/relax-require_one

relax require_one
flyingcircusio · Sep 10, 2024 · 3f10a8a · 3f10a8a
2 parents c980406 + 97714ef
commit 3f10a8a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,7 +4,7 @@
 ## 2.5.1 (unreleased)
 ---------------------
 
-- Nothing changed yet.
+- fix Component.require_one raising a configuration error with strict=False
 
 
 ## 2.5.0 (2024-09-04)

diff --git a/src/batou/component.py b/src/batou/component.py
@@ -655,9 +655,9 @@ def require_one(
                     key, host
                 )
             )
-        elif len(resources) == 0:
+        elif len(resources) == 0 and strict:
             raise SilentConfigurationError()
-        return resources[0]
+        return resources[0] if resources else None
 
     def assert_cmd(self, *args, **kw):
         """Assert that given command returns successfully, raise