Make sure that we auto close the JDBC Connection and Statement when e…

…xecuting a schema resource
flowable · Aug 20, 2024 · 346b85d · 346b85d
1 parent eab1f9c
commit 346b85d
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/...c/main/java/org/flowable/common/engine/impl/db/AbstractSqlScriptBasedDbSchemaManager.java b/...c/main/java/org/flowable/common/engine/impl/db/AbstractSqlScriptBasedDbSchemaManager.java
@@ -248,8 +248,7 @@ protected void executeSchemaResource(String operation, String component, String
         String sqlStatement = null;
         String exceptionSqlStatement = null;
         DbSqlSession dbSqlSession = getDbSqlSession();
-        try {
-            Connection connection = dbSqlSession.getSqlSession().getConnection();
+        try (Connection connection = dbSqlSession.getSqlSession().getConnection();) {
             Exception exception = null;
             byte[] bytes = IoUtil.readInputStream(inputStream, resourceName);
             String ddlStatements = new String(bytes, StandardCharsets.UTF_8);
@@ -318,12 +317,10 @@ protected void executeSchemaResource(String operation, String component, String
                             sqlStatement = addSqlStatementPiece(sqlStatement, line.substring(0, line.length() - 1));
                         }
 
-                        Statement jdbcStatement = connection.createStatement();
-                        try {
+                        try (Statement jdbcStatement = connection.createStatement();) {
 
                             logger.debug("SQL: {}", sqlStatement);
                             jdbcStatement.execute(sqlStatement);
-                            jdbcStatement.close();
 
                         } catch (Exception e) {
                             if (exception == null) {