Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export types #16

Merged
merged 8 commits into from
Dec 12, 2023
Merged

export types #16

merged 8 commits into from
Dec 12, 2023

Conversation

zeroXbrock
Copy link
Member

@zeroXbrock zeroXbrock commented Dec 9, 2023 •
edited
Loading

now you can

import type {
  SuaveWallet,
  SuaveProvider,
  TransactionRequestSuave,
  // ...
} from 'viem/chains/utils'

or

import type {
  SuaveProvider,
  SuaveWallet,
  TransactionRequestSuave
} from 'viem/_types/chains/utils'

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 58.15 KB (0%) 1.2 s (0%) 2 s (-4.54% 🔽) 3.2 s
viem (cjs) 76.86 KB (0%) 1.6 s (0%) 2.3 s (+29.5% 🔺) 3.9 s
viem (minimal surface - tree-shaking) 3.97 KB (0%) 80 ms (0%) 425 ms (+43.36% 🔺) 505 ms
viem/accounts 89.87 KB (+0.03% 🔺) 1.8 s (+0.03% 🔺) 710 ms (-50.94% 🔽) 2.6 s
viem/accounts (tree-shaking) 19.5 KB (0%) 390 ms (0%) 713 ms (+48.29% 🔺) 1.2 s
viem/actions 43.43 KB (0%) 869 ms (0%) 8.6 s (+27.39% 🔺) 9.4 s
viem/actions (tree-shaking) 348 B (0%) 10 ms (0%) 240 ms (-28.3% 🔽) 250 ms
viem/chains 17.88 KB (-70.27% 🔽) 358 ms (-70.27% 🔽) 422 ms (-73.07% 🔽) 780 ms
viem/chains (tree-shaking) 473 B (0%) 10 ms (0%) 487 ms (+52.45% 🔺) 497 ms
viem/chains/utils 49.75 KB (+521.32% 🔺) 996 ms (+521.32% 🔺) 531 ms (+25.21% 🔺) 1.6 s
viem/chains/utils (tree-shaking) 5.26 KB (0%) 106 ms (0%) 389 ms (+53.91% 🔺) 494 ms
viem/ens 43.43 KB (0%) 869 ms (0%) 5.3 s (-22.41% 🔽) 6.2 s
viem/ens (tree-shaking) 18.01 KB (0%) 361 ms (0%) 534 ms (+25.05% 🔺) 894 ms

dmarzzz
dmarzzz approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@dmarzzz dmarzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM

metachris
metachris reviewed Dec 11, 2023
View reviewed changes
examples/suave/bids/index.ts
@@ -65,7 +65,7 @@ export class MevShareBid {
return {
to: this.mevShareContract,
data: this.newBidCalldata(),
type: SuaveTxTypes.ConfidentialRequest,
type: '0x43',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why replace with hard-coded value instead of const?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use either one -- this is just more convenient, and a demonstration of what most people will likely do

andytudhope
andytudhope approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@andytudhope andytudhope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 👍

@zeroXbrock zeroXbrock merged commit a70c180 into main Dec 12, 2023
4 of 13 checks passed
@zeroXbrock zeroXbrock deleted the export-types branch December 12, 2023 18:50
@zeroXbrock zeroXbrock mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metachris metachris metachris left review comments

@dmarzzz dmarzzz dmarzzz approved these changes

@andytudhope andytudhope andytudhope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeroXbrock @metachris @andytudhope @dmarzzz