Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to compile contracts in order to run demo for tutorial #14

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

andytudhope
Copy link
Collaborator

I do worry about how heavy forge install is with suave-geth as a submodule, but hey, that's what we got for now.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 58.15 KB (0%) 1.2 s (0%) 1.6 s (+118.99% 🔺) 2.7 s
viem (cjs) 76.86 KB (0%) 1.6 s (0%) 938 ms (-29.55% 🔽) 2.5 s
viem (minimal surface - tree-shaking) 3.97 KB (0%) 80 ms (0%) 242 ms (+6.04% 🔺) 321 ms
viem/accounts 89.85 KB (0%) 1.8 s (0%) 759 ms (+79.53% 🔺) 2.6 s
viem/accounts (tree-shaking) 19.5 KB (0%) 390 ms (0%) 340 ms (+6.31% 🔺) 730 ms
viem/actions 43.43 KB (0%) 869 ms (0%) 4.7 s (-19.71% 🔽) 5.5 s
viem/actions (tree-shaking) 348 B (0%) 10 ms (0%) 308 ms (+154.32% 🔺) 318 ms
viem/chains 60.14 KB (0%) 1.3 s (0%) 578 ms (-37.47% 🔽) 1.8 s
viem/chains (tree-shaking) 473 B (0%) 10 ms (0%) 296 ms (+60.89% 🔺) 306 ms
viem/chains/utils 8.01 KB (0%) 161 ms (0%) 127 ms (+39.53% 🔺) 287 ms
viem/chains/utils (tree-shaking) 5.26 KB (0%) 106 ms (0%) 102 ms (-62.27% 🔽) 207 ms
viem/ens 43.43 KB (0%) 869 ms (0%) 3.6 s (-26.33% 🔽) 4.5 s
viem/ens (tree-shaking) 18.01 KB (0%) 361 ms (0%) 323 ms (-1.95% 🔽) 683 ms

@zeroXbrock
Copy link
Member

I do worry about how heavy forge install is with suave-geth as a submodule, but hey, that's what we got for now.

agreed, suave-geth is huge. Would be nice to have the contracts in their own repo

@dmarzzz
Copy link
Member

dmarzzz commented Dec 13, 2023

I do worry about how heavy forge install is with suave-geth as a submodule, but hey, that's what we got for now.

agreed, suave-geth is huge. Would be nice to have the contracts in their own repo

yeah this is the plan but we need things to stabilize a bit more first as it adds a bunch of friction

@andytudhope andytudhope merged commit 3ca2a46 into main Dec 13, 2023
6 of 13 checks passed
@andytudhope andytudhope deleted the smol-fix branch December 13, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants