End builder session on a New Block #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 7suyash7 <[email protected]>
7suyash7
requested review from
ferranbt,
Ruteri,
metachris and
dmarzzz
as code owners
ferranbt
approved these changes
Oct 7, 2024
suave/builder/builder.go
Outdated
|
|
||
| func (b *builder) Terminate() { | ||
| b.cancelFunc() | ||
| b.txns = nil |
There was a problem hiding this comment.
Why do you need to set this to nil?
There was a problem hiding this comment.
Misunderstood how context works here, fixed it.
ferranbt
requested changes
Oct 7, 2024
Signed-off-by: 7suyash7 <[email protected]>
ferranbt
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#167
Implement a mechanism to end builder sessions when a new block arrives, to avoid simulations on invalid states.
SessionManagernow subscribes toChainHeadEventSessionManageris closed.Terminatemethod tobuilderfor clean session ending.