Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Build blocks with blob txs #18

Closed
wants to merge 3 commits into from

Conversation

halo3mic
Copy link

@halo3mic halo3mic commented Feb 15, 2024

About

  • This is POC for building blocks with blob transactions.
  • It is tested and works for cases where Blobs == BlobTxs and when Blobs > BlobTxs. The case where BlobTxs < Blobs still needs to be handled.
  • This relates to PR POC: Support blocks with blob txs suave-geth#197

Example of successful blocks with this version

@lthibault
Copy link

@halo3mic are you looking into the test failure? No pressure, just want to track this. 😃

@halo3mic
Copy link
Author

@halo3mic are you looking into the test failure? No pressure, just want to track this. 😃

Haven't looked into it yet, will take a look tmrw probably :)

@halo3mic
Copy link
Author

Todo

  • Consider merging original geth code
  • Refactor / Optimise

@halo3mic
Copy link
Author

The logic that I added is present in the vanilla geth so it makes little sense to deviate from it and maintain some custom logic instead of just merging the latest geth changes into suave-execution-geth.

@halo3mic halo3mic closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants