Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support custom celEnvs when running expressions #46

Merged
merged 2 commits into from
Jan 17, 2024
Merged

feat: support custom celEnvs when running expressions #46

merged 2 commits into from
Jan 17, 2024

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Jan 16, 2024 •
edited
Loading

Adds support for

  • passing in template function of arbitrary signature instead of just func() any. Required in playbook actions, where getAction() needs to take in an argument
  • For cel expressions, complex functions can be supplied using the newly added gomplate.CelEnvs field

Disable template caching if custom functions are provided

@adityathebe adityathebe marked this pull request as draft January 16, 2024 14:28
@adityathebe adityathebe marked this pull request as ready for review January 17, 2024 05:39
@moshloop moshloop merged commit 5fe40aa into main Jan 17, 2024
5 checks passed
@adityathebe adityathebe deleted the feat/extend-function-support branch January 17, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshloop moshloop Awaiting requested review from moshloop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityathebe @moshloop