Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicates and prioritize methods over functions #38

Merged
merged 2 commits into from
Dec 17, 2023
Merged

fix: remove duplicates and prioritize methods over functions #38

merged 2 commits into from
Dec 17, 2023

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Dec 15, 2023 •
edited
Loading

  • namespace aws and k8s
  • remove json functions and added the corresponding methods instead

@adityathebe adityathebe force-pushed the fix/remove-functions branch 2 times, most recently from 8924a0b to 500b802 Compare December 15, 2023 13:20
moshloop
moshloop reviewed Dec 15, 2023
View reviewed changes
kubernetes/health.go Outdated Show resolved Hide resolved
@moshloop moshloop merged commit 82ece68 into main Dec 17, 2023
5 checks passed
@adityathebe adityathebe deleted the fix/remove-functions branch June 20, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshloop moshloop Awaiting requested review from moshloop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityathebe @moshloop