Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Local Processing agent to Hybrid Deployment and actualize #372

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Rename Local Processing agent to Hybrid Deployment and actualize #372

merged 1 commit into from
Nov 12, 2024

Conversation

fivetran-aleksandrboldyrev
Copy link
Contributor

No description provided.

@fivetran-aleksandrboldyrev fivetran-aleksandrboldyrev marked this pull request as ready for review November 4, 2024 18:58
beevital
beevital reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@beevital beevital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to introduce new resources and deprecate the old ones instead of "renaming".

And same for the fields in connector and destination resources - it's better to introduce a new field and deprecate the old one.

fivetran/framework/core/model/connector.go Show resolved Hide resolved
fivetran/framework/resources/connector_migrations.go Show resolved Hide resolved
fivetran/framework/core/schema/destination.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
beevital
beevital reviewed Nov 5, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
fivetran/framework/core/schema/connector.go Outdated Show resolved Hide resolved
fivetran/framework/core/schema/destination.go Outdated Show resolved Hide resolved
beevital
beevital approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@beevital beevital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please update descriptions for deprecated fields to reflect the deprecation fact in docs.

Please update templates/{resources|datasources}/local_processing_agent.md.tmpl with Deprecation disclaimer.

CHANGELOG.md Outdated Show resolved Hide resolved
fivetran/framework/core/schema/connector.go Outdated Show resolved Hide resolved
fivetran/framework/core/schema/destination.go Outdated Show resolved Hide resolved
@fivetran-aleksandrboldyrev fivetran-aleksandrboldyrev merged commit 6514d6a into main Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beevital beevital beevital approved these changes

@fivetran-jovanmanojlovic fivetran-jovanmanojlovic Awaiting requested review from fivetran-jovanmanojlovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fivetran-aleksandrboldyrev @beevital