feature(fivetran_sdk): Add support for DataType Param #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ediril
approved these changes
Jun 11, 2024
| }, | ||
| "campaign": { | ||
| "columns": { | ||
| "name": "STRING", |
There was a problem hiding this comment.
Let's keep this one like this to show that byte length is optional
fivetran-niketkhandelwal
pushed a commit
that referenced
this pull request
Jun 16, 2024
* added support for decimal params * incorporate comment
manjutapali
pushed a commit
that referenced
this pull request
Jun 18, 2024
* added support for decimal params * incorporate comment
manjutapali
pushed a commit
that referenced
this pull request
Jun 18, 2024
* added support for decimal params * incorporate comment
ediril
added a commit
that referenced
this pull request
Jun 21, 2024
* Changes to interfaces * fix(partner-sdk): updated the go example with the new proto changes (#35) * fix(partner-sdk): updated the go example with new proto changes * fix(partner-sdk): re-formatted the code * feature(partner_sdk): fix python destination examples as per updated proto files (#34) * fix python destination example * fixed tester issue * feature(partner_sdk): fix java examples as per updated proto files (#33) * fix(partner-sdk): updated the python example with updated proto interface (#38) * fix(partner-sdk): updated the python example with updated proto interface * fix(python-example): refactored the code * fix(python-example): added field as part of kwargs * fix(partner_sdk): change proto version to v2 (#39) * feature(partner_sdk): add example for max value in destination capabilities (#41) * feature(fivetran_sdk): Add support for DataType Param (#45) * added support for decimal params * incorporate comment * add max value example for python destination (#48) * Separated proto updates files into v2 files (#47) * separated updated proto files into v2, updated build files * updated the README file * addressed requested changes * addressed requested changes * removed comment * removed naive_time from old proto * fixed python example * fixed go example * addressed comments * fix(fivetran-sdk): fixed the field number * refactor(Partner_sdk): Improvement in examples (#50) improvements in examples Co-authored-by: Satvik Patil <[email protected]> * addressed requested comments, fixed python destination example * removed note --------- Co-authored-by: SatvikPatil <[email protected]> Co-authored-by: Satvik Patil <[email protected]> --------- Co-authored-by: Manjunath Tapali <[email protected]> Co-authored-by: Abdul Salam <[email protected]> Co-authored-by: Niket Khandelwal <[email protected]> Co-authored-by: SatvikPatil <[email protected]> Co-authored-by: Satvik Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links: https://fivetran.height.app/T-719486
Add DataTypeParam support and modified input file to support schemaDiffs