Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use left join for joining current sprint info #94

Draft
wants to merge 1 commit into
base: releases/v0.13.latest
Choose a base branch
from

Conversation

fivetran-jamie
Copy link
Contributor

Are you a current Fivetran customer?

internal

What change(s) does this PR introduce?

  • makes the join here a left join. this is necessary when the latest sprint value is truly null

Did you update the CHANGELOG?

  • Yes
    not yet

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • Buildkite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🧨

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-jamie fivetran-jamie changed the base branch from main to releases/v0.12.latest March 30, 2023 21:16
@fivetran-jamie fivetran-jamie changed the base branch from releases/v0.12.latest to releases/v0.13.latest April 3, 2023 20:31
@fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-jamie should we close this, or is this PR still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants