Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tests to data_tests as of dbt 1.8 #134

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

JustMaris
Copy link
Contributor

@JustMaris JustMaris commented Aug 12, 2024

Please provide your name and company
Maris, Easypark
Link the issue/feature request which this PR is meant to address
#133
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Renamed tests to data_tests
How did you validate the changes introduced within this PR?
Did a local run.
Which warehouse did you use to develop these changes?
Snowflake.
Did you update the CHANGELOG?

  • Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Provide an emoji that best describes your current mood

🐬

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

@JustMaris
Copy link
Contributor Author

Have updated changelog and project version. Guide me if I need to do something else or did something not fully correctly.

@JustMaris
Copy link
Contributor Author

I bumped lower dbt version to 1.8, as tests don't work with versions below 1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant