Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel test improvements #3865

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Parallel test improvements #3865

merged 3 commits into from
Nov 15, 2024

Conversation

connorjward
Copy link
Contributor

Description

Expunges calls to mpiexec in the test suite (should be handled by pytest-mpi). Also a big refactor of test_demos and some small linting fixes.

JDBetteridge
JDBetteridge previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@JDBetteridge JDBetteridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way better than what was there before

@connorjward connorjward enabled auto-merge (squash) November 14, 2024 17:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8081 ran6500 passed1581 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8087 ran7298 passed789 skipped0 failed

@connorjward connorjward merged commit 7155630 into master Nov 15, 2024
12 checks passed
@connorjward connorjward deleted the connorjward/parallel-test-fixes branch November 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDBetteridge JDBetteridge JDBetteridge left review comments

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorjward @JDBetteridge