Get value_shape from FunctionSpace #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pbrubeck
force-pushed
the
pbrubeck/value_shape
branch
2 times, most recently
from
e33bd64
to
4c5f7db
Compare
pbrubeck
commented
Nov 12, 2024
pbrubeck
force-pushed
the
pbrubeck/value_shape
branch
2 times, most recently
from
a2537dc
to
20342a6
Compare
pbrubeck
force-pushed
the
pbrubeck/value_shape
branch
from
20342a6
to
adb93f4
Compare
pbrubeck
force-pushed
the
pbrubeck/value_shape
branch
from
5ed339e
to
47253ea
Compare
pbrubeck
force-pushed
the
pbrubeck/value_shape
branch
2 times, most recently
from
b76ee5e
to
3bdaba7
Compare
pbrubeck
commented
Nov 13, 2024
pbrubeck
force-pushed
the
pbrubeck/value_shape
branch
from
3bdaba7
to
d6bb2ed
Compare
pbrubeck
force-pushed
the
pbrubeck/value_shape
branch
from
d6bb2ed
to
bb5a9bd
Compare
pbrubeck
force-pushed
the
pbrubeck/value_shape
branch
from
11c8ba1
to
0e4c04f
Compare
pbrubeck
commented
Nov 15, 2024
pbrubeck
commented
Nov 15, 2024
pbrubeck
force-pushed
the
pbrubeck/value_shape
branch
from
38e7f78
to
a07587e
Compare
connorjward
previously requested changes
Nov 15, 2024
There was a problem hiding this comment.
Generally this looks great. @ksagiyam can you also give this a scan to make sure it's the right thing.
pbrubeck
commented
Nov 15, 2024
pbrubeck
force-pushed
the
pbrubeck/value_shape
branch
from
2752f93
to
a674ccf
Compare
Co-authored-by: ksagiyam <[email protected]>
ksagiyam
previously approved these changes
Nov 15, 2024
ksagiyam
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
V.ufl_element().value_shapebyV.value_shape,firedrake.FunctionSpace.value_sizehas been redefined to agree withufl.FunctionSpace.value_size = numpy.prod(value_shape, int), so the old behaviour gets renamed asfiredrake.FunctionSpace.block_sizeDepends on:
firedrakeproject/ufl#52
FInAT/FInAT#118
firedrakeproject/tsfc#307