Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function space: fix collapse #3861

Merged
merged 1 commit into from
Nov 13, 2024
Merged

function space: fix collapse #3861

merged 1 commit into from
Nov 13, 2024

Conversation

ksagiyam
Copy link
Contributor

Fix V.collapse().

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8090 ran6507 passed1583 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8096 ran7310 passed786 skipped0 failed

pbrubeck
pbrubeck reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@pbrubeck pbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksagiyam ksagiyam merged commit d12e3ac into master Nov 13, 2024
12 checks passed
@ksagiyam ksagiyam deleted the ksagiyam/fix_fs_collapse branch November 13, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrubeck pbrubeck pbrubeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksagiyam @pbrubeck