Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dolci/exchange fwi demo test #3836

Merged
merged 13 commits into from
Nov 7, 2024
Merged

Dolci/exchange fwi demo test #3836

merged 13 commits into from
Nov 7, 2024

Conversation

Ig-dolci
Copy link
Contributor

@Ig-dolci Ig-dolci commented Oct 24, 2024 •
edited
Loading

Description

Add FIREDRAKE_CI environment in test_demos.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8090 ran6507 passed1583 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8096 ran7310 passed786 skipped0 failed

dham
dham requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@dham dham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deals with the proximate problem but violates single source of truth. We need to put a mode into the demo that makes it faster (possibly by branching on an environment variable).

connorjward
connorjward previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@connorjward connorjward enabled auto-merge (squash) November 7, 2024 11:38
@connorjward connorjward merged commit cdf04f6 into master Nov 7, 2024
12 checks passed
@connorjward connorjward deleted the dolci/exchange_fwi_demo_test branch November 7, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjward connorjward connorjward approved these changes

@dham dham dham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ig-dolci @dham @connorjward