Trefftz support for Firedrake #3775
Conversation
Signed-off-by: Umberto Zerbinati <[email protected]>
|
|
Signed-off-by: Umberto Zerbinati <[email protected]>
Signed-off-by: Umberto Zerbinati <[email protected]>
Signed-off-by: Umberto Zerbinati <[email protected]>
UZerbinati
force-pushed
the
uz/trefftz
branch
from
faa6e24
to
fe9643f
Compare
firedrake/trefftz.py
Outdated
| Assemble the embedding, compute the SVD and return the embedding matrix | ||
| """ | ||
| self.B = assemble(self.b).M.handle | ||
| if self.backend == "scipy": |
There was a problem hiding this comment.
Does this work in parallel? We should have a parallel test.
There was a problem hiding this comment.
Not sure having a backend way we want to do this either...
tests/regression/test_trefftz.py
Outdated
|
|
||
| @pytest.mark.skipcomplex | ||
| def test_trefftz_aggregation(): | ||
| from netgen.occ import WorkPlane, OCCGeometry |
There was a problem hiding this comment.
This test needs to be skipped if ngsPETSc is not installed
firedrake/trefftz.py
Outdated
| """ | ||
| This class computes the Trefftz embedding of a given function space | ||
| Parameters |
There was a problem hiding this comment.
| """ | |
| This class computes the Trefftz embedding of a given function space | |
| Parameters | |
| """Compute the Trefftz embedding of a given function space. | |
| Parameters |
There was a problem hiding this comment.
Similarly for other docstrings
firedrake/trefftz.py
Outdated
| This class computes the Trefftz embedding of a given function space | ||
| Parameters | ||
| ---------- | ||
| V : :class:`.FunctionSpace` |
There was a problem hiding this comment.
Please remove types from here and add type-hinting, see policy.
firedrake/trefftz.py
Outdated
| Assemble the embedding, compute the SVD and return the embedding matrix | ||
| """ | ||
| self.B = assemble(self.b).M.handle | ||
| if self.backend == "scipy": |
There was a problem hiding this comment.
Not sure having a backend way we want to do this either...
firedrake/trefftz.py
Outdated
| return QTpsc, sig | ||
|
|
||
|
|
||
| class trefftz_ksp(object): |
There was a problem hiding this comment.
| class trefftz_ksp(object): | |
| class TrefftzKSP: |
firedrake/trefftz.py
Outdated
| import scipy.sparse as sp | ||
|
|
||
|
|
||
| class TrefftzEmbedding(object): |
There was a problem hiding this comment.
| class TrefftzEmbedding(object): | |
| class TrefftzEmbedding: |
|
Hi Umberto! Are you going to put this PR up on screen during your talk by any chance? |
Signed-off-by: Umberto Zerbinati <[email protected]>
| from ufl import dx, dS, inner, jump, grad, dot, CellDiameter, FacetNormal | ||
| import scipy.sparse as sp | ||
|
|
||
|
|
There was a problem hiding this comment.
Please define __all__ to avoid pollution of the namespace
There was a problem hiding this comment.
Or equivalently you can replace from firedrake.trefftz import * with from firedrake.trefftz import OnlyWhatIWant inside __init__.py.
Signed-off-by: Umberto Zerbinati <[email protected]>
Signed-off-by: Umberto Zerbinati <[email protected]>
Signed-off-by: Umberto Zerbinati <[email protected]>
No description provided.