Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UFL element interface #3122

Closed
wants to merge 26 commits into from
Closed

Update UFL element interface #3122

wants to merge 26 commits into from

Conversation

mscroggs
Copy link
Contributor

@mscroggs mscroggs commented Sep 26, 2023

These changes (and firedrakeproject/tsfc#300 and NGSolve/ngsPETSc#5) will be required once FEniCS/ufl#197 is merged into the Firedrake fork of UFL

Docs build on CI is failing as it's using the wrong UFL branch.

@mscroggs mscroggs marked this pull request as draft September 26, 2023 08:47
@ksagiyam
Copy link
Contributor

Hi Matt,

Thanks for working on this. It turned out that this was my fault.
This failing piece shouldn't be tested in parallel, as variable layer extrusion is broken in parallel: #2169.
Could you please make tests/output/test_io_mesh.py::test_io_mesh_uniform_variable_layers a serial test (just by removing the @pytest.mark.parallel(nprocs=3))?

I do not know why this test has been passing, and why your changes exhibit the issue, but this test is not expected to work in parallel.

I'm sorry.

@mscroggs
Copy link
Contributor Author

Hi Matt,

Thanks for working on this. It turned out that this was my fault. This failing piece shouldn't be tested in parallel, as variable layer extrusion is broken in parallel: #2169. Could you please make tests/output/test_io_mesh.py::test_io_mesh_uniform_variable_layers a serial test (just by removing the @pytest.mark.parallel(nprocs=3))?

I do not know why this test has been passing, and why your changes exhibit the issue, but this test is not expected to work in parallel.

I'm sorry.

No need to be sorry, this is great news, as it means I haven't broken anything major!

@mscroggs
Copy link
Contributor Author

mscroggs commented Nov 2, 2023

Closing this in favour of #3166

@mscroggs mscroggs closed this Nov 2, 2023
@mscroggs mscroggs deleted the mscroggs/newfl-legacy branch November 15, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants