Fix for Windows x64 builds (WiX Heat ATLHarvester support) #145
Conversation
* Adds ATLHarvester extension support to WiX buildscripts * Added python script to fix some minor screwups that ATLHarvester makes * Added x64 editions of FixFragment*.xslt * Candle now gets told to use x64 support when building for that arch. * README updated with new/clarified Windows dependencies. Yes, I'm aware there's probably a better way to do this, but it Works For Me(tm).
|
Hmm. My one concern with this (even though it's awesome) is that it adds a dependency on python that previously did not exist. Is there any way to do this without the python script? What screwups does ATLHarvester make? |
|
Well, for example: <w:Component ... Directory="dir99DE416F55C8960850D5A4FCA3758AD4">
<!-- As opposed to the correct -->
<w:Component ... Directory="TARGETDIR">It also screws up the path of the plugin DLL for some reason. All the python script does is hunt down the broken elements with xpath rules and replace them with ones that work. Then again, I'm very much a newbie to working with COM, so I have no idea what the hell ATLHarvester is trying to do. All I know is that making these fixes produces a working WiX installer. If someone wants to improve this, they're welcome to do so. For example, a simple C# app can probably do the same thing. All I'm doing is giving you the same crap I use to get this to work for me. |
|
Hmm; if that's the case, is it possible that we could fix it using the xslt transformation instead? |
| } | ||
| def FixWix(infile, outfile): | ||
| tree = None | ||
| with open(infile,'r') as f: |
There was a problem hiding this comment.
Please change it to 'rb' instead.
Yes, I'm aware there's probably a better way to do this, but it Works For Me™.