Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(histogram): delete misleading words in exception message #1890

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

Boyuan-Yu
Copy link
Contributor

@Boyuan-Yu Boyuan-Yu commented Nov 13, 2024

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Removed 'size' from error message to clarify bucket configuration differences and avoid misleading users about bucket sizes.

@Boyuan-Yu Boyuan-Yu changed the title delete misleading words in exception message feat(histogram): delete misleading words in exception message Nov 13, 2024
sandeep6189
sandeep6189 previously approved these changes Nov 13, 2024
@sandeep6189 sandeep6189 changed the title feat(histogram): delete misleading words in exception message fix(histogram): delete misleading words in exception message Nov 13, 2024
@Boyuan-Yu Boyuan-Yu marked this pull request as ready for review November 13, 2024 22:02
@sandeep6189 sandeep6189 merged commit 59a514f into filodb:develop Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants