Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(query): increment counter when query plan updated with next level aggregated metric #1863

Merged
merged 2 commits into from
Oct 8, 2024
Merged

misc(query): increment counter when query plan updated with next level aggregated metric #1863

merged 2 commits into from
Oct 8, 2024

Conversation

sandeep6189
Copy link
Contributor

@sandeep6189 sandeep6189 commented Oct 3, 2024 •
edited
Loading

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior : No metric to track the updated hierarchical query plans.

New behavior :

  1. Added a counter to track the updated hierarchical query plans
  2. Added capability to test kamon metric updates in our unit tests

alextheimer
alextheimer approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@alextheimer alextheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sandeep6189 sandeep6189 merged commit 6d0e997 into filodb:develop Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yu-shipit yu-shipit yu-shipit left review comments

@alextheimer alextheimer alextheimer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandeep6189 @alextheimer @yu-shipit