Fix codecov upload #668
Closed
Fix codecov upload #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #668 +/- ##
===========================================
+ Coverage 98.87% 99.19% +0.32%
===========================================
Files 23 24 +1
Lines 974 1245 +271
===========================================
+ Hits 963 1235 +272
+ Misses 11 10 -1 ☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
added
the
fenicsx
jhdark
approved these changes
Dec 12, 2023
|
Well it didn't fix it correctly since it still seems to fail (just look at the last commit it started not finding the token again...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the upload to codecov which randomely failed.
After a long discussion with the codecov team codecov/feedback#180 we found out that the problem was that the CODECOV_TOKEN secret wasn't passed correctly.
The solution was to define the secret at the job level and not at the step level.
I reported this bug to Github https://github.com/orgs/community/discussions/78847
NOTE: a similar change will have to be done on the main branch