Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMS testing #663

Closed
wants to merge 64 commits into from
Closed

MMS testing #663

wants to merge 64 commits into from

Conversation

jhdark
Copy link
Collaborator

@jhdark jhdark commented Dec 7, 2023

Proposed changes

MMS testing! This PR starts to build up an MMS testing suite for vigorous verification testing. @RemDelaporteMathurin See what you think so far. I've adapted the tests in fenicsx tutorial.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.24%. Comparing base (be788e4) to head (5a9bd96).
Report is 11 commits behind head on fenicsx.

Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx     #663      +/-   ##
===========================================
+ Coverage    99.05%   99.24%   +0.18%     
===========================================
  Files           26       26              
  Lines         1168     1186      +18     
===========================================
+ Hits          1157     1177      +20     
+ Misses          11        9       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhdark jhdark marked this pull request as ready for review December 11, 2023 16:32
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good.

We need to define a test matrix like varying temperature, transient, flux boundary condition, 2D, etc. to make sure we cover all the features of the code.

Also I would add some general documentation (comments) to explain what's done in the test.

test/test_mms.py Outdated Show resolved Hide resolved
test/test_mms.py Outdated Show resolved Hide resolved
test/test_mms.py Outdated Show resolved Hide resolved
test/test_mms.py Outdated Show resolved Hide resolved
test/test_mms.py Outdated Show resolved Hide resolved
@RemDelaporteMathurin RemDelaporteMathurin added the fenicsx Issue that is related to the fenicsx support label Dec 12, 2023
@jhdark
Copy link
Collaborator Author

jhdark commented Dec 15, 2023

@RemDelaporteMathurin here are basic examples of the types of MMS tests we could do. But perhaps we can discuss further in the general channel on Slack for what should be covered with MMS testing

festim/source.py Outdated Show resolved Hide resolved
test/test_mms.py Outdated Show resolved Hide resolved
@jhdark
Copy link
Collaborator Author

jhdark commented Mar 20, 2024

I rebased from fenicsx, but theres still, if not more, changes that are already in that branch? Not sure if I should merge or not?

@RemDelaporteMathurin RemDelaporteMathurin changed the base branch from fenicsx to RemDelaporteMathurin-patch-1 March 20, 2024 12:13
@RemDelaporteMathurin RemDelaporteMathurin changed the base branch from RemDelaporteMathurin-patch-1 to fenicsx March 20, 2024 12:13
@RemDelaporteMathurin RemDelaporteMathurin changed the base branch from fenicsx to main March 20, 2024 12:27
@RemDelaporteMathurin RemDelaporteMathurin changed the base branch from main to fenicsx March 20, 2024 12:28
@jhdark
Copy link
Collaborator Author

jhdark commented Mar 27, 2024

Remaking PR due to bugs from not detecting changes to fenicsx branch

@jhdark jhdark closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fenicsx Issue that is related to the fenicsx support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants