-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMS testing #663
MMS testing #663
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #663 +/- ##
===========================================
+ Coverage 99.05% 99.24% +0.18%
===========================================
Files 26 26
Lines 1168 1186 +18
===========================================
+ Hits 1157 1177 +20
+ Misses 11 9 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good.
We need to define a test matrix like varying temperature, transient, flux boundary condition, 2D, etc. to make sure we cover all the features of the code.
Also I would add some general documentation (comments) to explain what's done in the test.
@RemDelaporteMathurin here are basic examples of the types of MMS tests we could do. But perhaps we can discuss further in the general channel on Slack for what should be covered with MMS testing |
Co-authored-by: James Dark <[email protected]>
I rebased from fenicsx, but theres still, if not more, changes that are already in that branch? Not sure if I should merge or not? |
Remaking PR due to bugs from not detecting changes to fenicsx branch |
Proposed changes
MMS testing! This PR starts to build up an MMS testing suite for vigorous verification testing. @RemDelaporteMathurin See what you think so far. I've adapted the tests in fenicsx tutorial.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...