Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
  • Loading branch information
jhdark and RemDelaporteMathurin authored Dec 4, 2023
1 parent 9caaf12 commit b9094bd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion festim/hydrogen_transport_problem.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def species(self, value):

def initialise(self):
# if traps are given, create the necessary objects
if len(self.traps) >= 1:
if len(self.traps) >0:
self.create_species_from_trap()

self.define_function_spaces()
Expand Down
2 changes: 1 addition & 1 deletion test/test_species.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def test_implicit_species_concentration_with_no_solution():


def test_create_species_and_reaction():
"""test that the trapped_concentration and trap_reaction attribites
"""test that the trapped_concentration and trap_reaction attributes
are correctly set"""

# BUILD
Expand Down

0 comments on commit b9094bd

Please sign in to comment.