Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented search in note feature #749

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

implemented search in note feature #749

wants to merge 1 commit into from

Conversation

oscarli9
Copy link

No description provided.

@oscarli9
Copy link
Author

Screenshot_1584226583_meitu_2
This is the screenshot of the note editing interface after modification. It will highlight every matched piece of text.

@federicoiosue
Copy link
Owner

Thanks awesome!
I'd have to move back to work on the UI branch because a lot of things have to be updated to modern material UI.

The final result should be something like this, but I don't think you'll be able to achieve that without changing quite a lot of code related to toolbar component

@federicoiosue federicoiosue force-pushed the develop branch 6 times, most recently from 9d11b98 to 0f78b8c Compare July 31, 2020 08:43
@federicoiosue federicoiosue force-pushed the develop branch 2 times, most recently from cbb03b8 to 11c97fd Compare May 4, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sayanta66 Sayanta66 Sayanta66 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oscarli9 @federicoiosue @Sayanta66