Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signup button to feedback panel #6548

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+55 −3
Open

Add signup button to feedback panel #6548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion fec/fec/static/js/templates/feedback.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,18 @@
</div>
<form id="feedback-form" class="container">
<fieldset>
<h3 class="t-sans">Post public feedback about the FEC.gov website anonymously</h3>
<h2>Help us improve FEC.gov</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we consider feature flagging this for only when we have a usability testing coming up? Or do we specifically want it permanent ?

<h3 class="t-sans">Test new website features with our design team</h3>
<div class="card--feedback">
<div class="card__left">
<a class="button--cta" href="">Sign up</a>
</div>
<div class="card__right">
<p class="t-sans t-note">Sign up for a 30-minute video call to help us test new website features.</p>
</div>
</div>
<hr>
<h3 class="t-sans">Or post public feedback about the FEC.gov website anonymously</h3>
<p class="t-sans t-note">How can we improve FEC.gov? Your feedback, browser information and the URL of the page you were viewing at the time of submission will be posted publicly - so don't include sensitive information like your name, contact information or Social Security number.</p>
<label for="feedback-1" class="label">What were you trying to do on fec.gov, and how can we improve it? <span class="label--help">(required)</span></label>
<textarea id="feedback-1" name="action"></textarea>
Expand Down
21 changes: 20 additions & 1 deletion fec/fec/static/scss/components/_feedback.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
}

hr {
border-top: 1px dotted $gray-dark;
border-bottom: 1px dotted $gray-dark;
margin: u(0 0 1rem 0);
}

Expand Down Expand Up @@ -70,6 +70,25 @@
top: u(1rem);
}

.card--feedback {
display: flex;
flex-direction: row;

.card__left {
padding: 1rem 1rem 1rem 0;
a {
white-space: nowrap;
}
}
.card__right {
padding: 1rem 0 1rem 1rem;

p {
margin-bottom: 0;
}
}
}

@include media($lg) {
@include transition(top .5s);
height: 95vh;
Expand Down
11 changes: 11 additions & 0 deletions fec/home/templates/purgecss-homepage/full.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,6 +941,17 @@ <h2>Glossary</h2>
</div>
<form id="feedback-form" class="container">
<fieldset>
<h2>Help us improve FEC.gov</h2>
<h3 class="t-sans">Test new website features with our design team</h3>
<div class="card--feedback">
<div class="card__left">
<a class="button--cta" href="https://ethn.io/12085">Sign up</a>
</div>
<div class="card__right">
<p class="t-sans t-note">Sign up for a 30-minute video call to help us test new website features.</p>
</div>
</div>
<hr>
<h3 class="t-sans">Post public feedback about the FEC.gov website anonymously</h3>
<p class="t-sans t-note">How can we improve FEC.gov? Your feedback, browser information and the URL of the page you were viewing at the time of submission will be posted publicly - so don't include sensitive information like your name, contact information or Social Security number.</p>
<label for="feedback-1" class="label">What were you trying to do on fec.gov, and how can we improve it? <span class="label--help">(required)</span></label>
Expand Down
13 changes: 12 additions & 1 deletion fec/home/templates/purgecss-homepage/toggled.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,17 @@ <h2>Glossary</h2>
</div>
<form id="feedback-form" class="container">
<fieldset>
<h2>Help us improve FEC.gov</h2>
<h3 class="t-sans">Test new website features with our design team</h3>
<div class="card--feedback">
<div class="card__left">
<a class="button--cta" href="">Sign up</a>
</div>
<div class="card__right">
<p class="t-sans t-note">Sign up for a 30-minute video call to help us test new website features.</p>
</div>
</div>
<hr>
<h3 class="t-sans">Post public feedback about the FEC.gov website anonymously</h3>
<p class="t-sans t-note">How can we improve FEC.gov? Your feedback, browser information and the URL of the page you were viewing at the time of submission will be posted publicly - so don't include sensitive information like your name, contact information or Social Security number.</p>
<label for="feedback-1" class="label">What were you trying to do on fec.gov, and how can we improve it? <span class="label--help">(required)</span></label>
Expand Down Expand Up @@ -94,4 +105,4 @@ <h3 class="t-sans">Post public feedback about the FEC.gov website anonymously</h
</form>
</div>
</div></body></html>